Hi while importing the barber script from the forums i wanted to make another npc to change race, factions or customize i and i found working scripts but... we are missing flags

enum AtLoginFlags
{
    AT_LOGIN_NONE              = 0x000,
    AT_LOGIN_RENAME            = 0x001,
    AT_LOGIN_RESET_SPELLS      = 0x002,
    AT_LOGIN_RESET_TALENTS     = 0x004,
    AT_LOGIN_CUSTOMIZE         = 0x008,
    AT_LOGIN_RESET_PET_TALENTS = 0x010,
    AT_LOGIN_FIRST             = 0x020,
    AT_LOGIN_CHANGE_FACTION    = 0x040,
    AT_LOGIN_CHANGE_RACE       = 0x080,
    AT_LOGIN_RESURRECT         = 0x100,
};

so i thought it would be cool if we can have these flags too since they are in TrinityCore master branche

otherwise i need to manually implement then and make tons of patches.

What should do this script ?

If this is added to the core you will be able to use those flags for custom content otherwise we have only Flag NONE and RENAME

i know for sure that change faction is not even supported in client 2.4.3, so i doubt if just adding that flag will help.

5 (edited by cyberpro 2016-06-07 18:19:11)

Player.h     ->

// 2^n values
enum AtLoginFlags
{
    AT_LOGIN_NONE          = 0,
    AT_LOGIN_RENAME        = 1,
    AT_LOGIN_RESET_SPELLS  = 2,
    AT_LOGIN_RESET_TALENTS = 4
};

I have different than yours ? So ?
Can i add your ? or to modify mine  ? i mean because you have the code
AT_LOGIN_NONE = 0x000,
    AT_LOGIN_RENAME = 0x001,
    AT_LOGIN_RESET_SPELLS = 0x002,
    AT_LOGIN_RESET_TALENTS = 0x004,
    AT_LOGIN_CUSTOMIZE = 0x008,
    AT_LOGIN_RESET_PET_TALENTS = 0x010,
    AT_LOGIN_FIRST = 0x020,
    AT_LOGIN_CHANGE_FACTION = 0x040,
    AT_LOGIN_CHANGE_RACE = 0x080,
    AT_LOGIN_RESURRECT = 0x100,


So should i change it with this
AT_LOGIN_NONE = 1,
    AT_LOGIN_RENAME = 2,
    AT_LOGIN_RESET_SPELLS = 3,
    AT_LOGIN_RESET_TALENTS = 4,
    AT_LOGIN_CUSTOMIZE = 5,
    AT_LOGIN_RESET_PET_TALENTS = 6,
    AT_LOGIN_FIRST = 7,
    AT_LOGIN_CHANGE_FACTION = 8,
    AT_LOGIN_CHANGE_RACE = 9,
    AT_LOGIN_RESURRECT = 10,


???????

dikkedeur wrote:

i know for sure that change faction is not even supported in client 2.4.3, so i doubt if just adding that flag will help.

i think he is right, the client will not support this flags, you can add it but it will have no effect on your client

if you want to make it possible you should go with database alterations, meaning you must make a code that deletes the character ( in case of faction change ) makes the new char, gives him the spells and whole crap and god know what else.
there is truly no client support for change faction in tbc the easy way, it was implemented by blizz on 3.x so it will not work.
So enjoy hacking tongue

Damn that sounds like lots of work XDD not gonna do it now.. maybe later

Because these flags ARE NOT used in 2.4.3. Very rarely are we backporting any flags such as these just for the sake of keeping compatibility. If we know for sure they're not used, or used in specific cases, we won't touch 'em.